Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AllDisplayLevelsSelecteded typo #574

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fix AllDisplayLevelsSelecteded typo #574

merged 3 commits into from
Jun 6, 2024

Conversation

williambohrmann3
Copy link
Collaborator

Deprecates AllDisplayLevelsSelecteded and replaces with AllDisplayLevelsSelected.

@williambohrmann3 williambohrmann3 self-assigned this Jun 3, 2024
@williambohrmann3 williambohrmann3 linked an issue Jun 3, 2024 that may be closed by this pull request
FloorFilter - typo in API #499
Closed
dotMorten
dotMorten reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Also note that this binding should now work:

It would be good to verify that it acts like expected

src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs Show resolved Hide resolved
mstefarov
mstefarov approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@mstefarov mstefarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest one more attribute, but otherwise this PR looks good to me

src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs Show resolved Hide resolved
@williambohrmann3
Copy link
Collaborator Author

@dotMorten verified bindings

@williambohrmann3 williambohrmann3 merged commit 44f8d9a into main Jun 6, 2024
1 check passed
@williambohrmann3 williambohrmann3 deleted the wbohr/AllDisplayLevelsSelecteded branch June 6, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotMorten dotMorten dotMorten approved these changes

@mstefarov mstefarov mstefarov approved these changes

Assignees

@williambohrmann3 williambohrmann3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FloorFilter - typo in API
3 participants
@williambohrmann3 @mstefarov @dotMorten